Repository navigation
Port problem file markdown to league/commonmark 2 - #309
Merged
Merged
Conversation
This was referenced Oct 22, 2026
Merged
Merged
AydinHassan
added this pull request to stack #311
October 22, 2026 16:09
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 16:11
17db790 to
a5eea60
Compare
AydinHassan
removed this pull request from stack #311
October 22, 2026 16:20
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 16:21
a5eea60 to
451ca02
Compare
AydinHassan
added this pull request to stack #313
October 22, 2026 16:21
AydinHassan
removed this pull request from stack #313
October 22, 2026 16:26
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 16:27
451ca02 to
35dd605
Compare
AydinHassan
added this pull request to stack #314
October 22, 2026 16:27
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 18:19
35dd605 to
f84025b
Compare
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 18:35
f84025b to
afc67c3
Compare
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 18:40
afc67c3 to
8d454f1
Compare
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
2 times, most recently
from
October 22, 2026 18:45
8af0235 to
d2e5005
Compare
AydinHassan
removed this pull request from stack #314
October 22, 2026 18:52
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 18:53
d2e5005 to
8826712
Compare
AydinHassan
added this pull request to stack #315
October 22, 2026 18:53
AydinHassan
removed this pull request from stack #315
October 22, 2026 18:53
AydinHassan
added this pull request to stack #317
October 22, 2026 18:53
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 19:00
8826712 to
bd971fa
Compare
Upgrade to PHPStan 2
Stop leaking the environment to student code
CI: PHP 8.2-8.5, job timeout, stop on first error
Newer symfony/process does not accept a null command, which ExecutableFinder::find() returns when composer is missing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fail clearly when composer cannot be found in WorkshopExerciseTest
Use php-school/cli-md-renderer 2 and keylighter 0.8.5. Port the context specific block, handlebar shorthands and renderer to the commonmark 2 parser and renderer APIs. Restore bold and italics, lost when problem files moved to a bare environment in 0c3e088. Tests still to be migrated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test the v2 block start/continue parsers, inline parser and renderer, using a real environment built like app/config.php. Add rendering tests for bold and emphasis. Remove the unused BlockStub. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The continue parser skipped the leading whitespace of every line in the block, so indented code lost its indentation. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AydinHassan
force-pushed
the
stack/2-commonmark2
branch
from
October 22, 2026 19:25
5240a1e to
2a5a370
Compare
An error occurred while trying to automatically change base from
stack/1f-ci
to
master
October 22, 2026 19:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of a stack replacing #300. Review in order; each PR is based on the previous one.
Via php-school/cli-md-renderer 2.0 and keylighter 0.8.5; restores bold/italic in problem files. Also requires cli-menu ^4.5 (terminal 0.3). Clears all composer audit advisories.
馃 Generated with Claude Code