Repository navigation
Docker sandbox, modern dependencies and commonmark 2 - #300
Closed
AydinHassan wants to merge 25 commits into
Closed
AydinHassan wants to merge 25 commits into
AydinHassan wants to merge 25 commits into
Conversation
AydinHassan
force-pushed
the
docker-fixes
branch
2 times, most recently
from
September 4, 2024 11:15
a2cdb65 to
d97450f
Compare
AydinHassan
force-pushed
the
docker-fixes
branch
from
September 4, 2024 11:18
55f6905 to
35ef773
Compare
Run student code with plain `docker run` using the workshop's runtime image, with all isolation enforced by the factory so workshops cannot loosen it: no network (composer gets network but no plugins/scripts), read-only root fs with a small /tmp, all capabilities dropped, no-new-privileges, pid/memory/cpu limits, and a timeout enforced inside the container. Exposed ports bind to loopback only. Add createBuildProcess() to build the runtime image at deploy time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Allow php-di 7, psr/container 2, psr/http-message 2, psr/log 2/3, Symfony 7/8 and Guzzle 8, and move to nikic/php-parser 5. Require PHP ^8.2. Point the composer install test fixture at a package that current Composer will install. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…op yoast/phpunit-polyfills Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Static data providers with attributes, withConsecutive replaced by a local helper, setMethods/getMockForAbstractClass/getName removed, polyfills dropped, phpunit.xml migrated to the 11.5 schema. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…Router Add a stub for the untyped kevinlebrun/colors.php library, add cli_arguments(), validate loaded config files, and remove always-true strpos(...) !== null checks. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Typed stubs for the untyped Colors and KeyLighter libraries, simplified EventDispatcherFactory merging, validated JSON user state, generic ArrayObject map/collapse, and several nullable/mixed fixes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…HPStan ignore Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the exclusion and ignore, and fix the issues it hid (container type, possibly undefined result variable, untyped container lookups). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the clover coverage flag: the job runs with coverage: none. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Use php-school/cli-md-renderer 2 and keylighter 0.8.5. Port the context specific block, handlebar shorthands and renderer to the commonmark 2 parser and renderer APIs. Restore bold and italics, lost when problem files moved to a bare environment in 0c3e088. Tests still to be migrated. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Test the v2 block start/continue parsers, inline parser and renderer, using a real environment built like app/config.php. Add rendering tests for bold and emphasis. Remove the unused BlockStub. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The env was stripped using $_ENV, which is empty when variables_order lacks E, so secrets leaked to the process. When it was populated, PATH was removed too, so composer could not find php. Input env now also overrides the defaults. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AydinHassan
changed the title
This was referenced Oct 22, 2026
Merged
Merged
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges together with phpschool.io
online(no tag until then).Sandbox
DockerProcessFactoryhardened: no network by default (bridge only for composer, run with--no-plugins --no-scripts), ports bound to 127.0.0.1, read-only root + tmpfs/tmp, all capabilities dropped,no-new-privileges, pids/memory/CPU limits, 30s kill timeoutHostProcessFactorystrips the inherited env viagetenv()and keeps onlyPATH/HOME/COMPOSER_HOME. It used$_ENV, which is empty whenvariables_orderlacksE(secrets leaked) and removedPATHwhen it was populated (composer could not find php)Dependencies
composer audit: cleanCI
--stop-on-error🤖 Generated with Claude Code