Skip to content

Upgrade to PHPStan 2 - #307

Merged
AydinHassan merged 17 commits into
masterfrom
stack/1e-phpstan2
Oct 22, 2026
Merged

AydinHassan merged 17 commits into
masterfrom
stack/1e-phpstan2

Conversation

@AydinHassan

@AydinHassan AydinHassan commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Part of a stack replacing #300. Review in order; each PR is based on the previous one.

PHPStan 2 at level max on src with no baseline, plus the typing fixes it needed.

🤖 Generated with Claude Code

AydinHassan and others added 7 commits October 22, 2026 20:33
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r PHPStan 2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Typed stubs for the untyped Colors and KeyLighter libraries, simplified
EventDispatcherFactory merging, validated JSON user state, generic ArrayObject
map/collapse, and several nullable/mixed fixes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…HPStan ignore

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Drop the exclusion and ignore, and fix the issues it hid (container type,
possibly undefined result variable, untyped container lookups).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t::implode

The listener merging only needed its docblock types fixing: listener groups are keyed by name, not int.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AydinHassan and others added 2 commits October 22, 2026 20:39
…ions

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
AydinHassan and others added 6 commits October 22, 2026 20:42
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AydinHassan
AydinHassan removed this pull request from stack #314 October 22, 2026 18:52
@AydinHassan
AydinHassan changed the base branch from stack/1d-phpunit11 to master October 22, 2026 18:52
@AydinHassan
AydinHassan added this pull request to stack #315 October 22, 2026 18:53
@AydinHassan
AydinHassan removed this pull request from stack #315 October 22, 2026 18:53
@AydinHassan
AydinHassan added this pull request to stack #317 October 22, 2026 18:53
AydinHassan and others added 2 commits October 22, 2026 20:59
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@AydinHassan
AydinHassan merged commit 7c9c32c into master Oct 22, 2026
2 checks passed
@AydinHassan
AydinHassan deleted the stack/1e-phpstan2 branch October 22, 2026 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant