Skip to content

feat(aws): add help completion - #2639

Open
ump45nose wants to merge 1 commit into
withfig:masterfrom
ump45nose:feat-aws-help
Open

ump45nose wants to merge 1 commit into
withfig:masterfrom
ump45nose:feat-aws-help

Conversation

@ump45nose

Copy link
Copy Markdown

What

Adds the top-level help subcommand to the aws spec, so aws help completes like the other subcommands (issue #1986).

aws help (and aws <command> help) are real, documented invocations of the AWS CLI v2; the spec currently offers no completion for them.

Scope note

This PR adds the top-level help entry only. The per-service lazy-loaded specs (aws/<service>) would each need the same entry for aws <service> help; that is a mechanical follow-up across ~300 files that did not seem worth bundling here.

Fixes #1986

Validation

  • npx eslint src/aws.ts and npx prettier --check pass.
  • Full-repo tsc --noEmit reports no errors in src/aws.ts (pre-existing errors in unrelated specs only).

aws help is a real subcommand (aws help, aws <command> help). Add it to
the top-level spec so it is suggested like the other service
subcommands.
@withfig-bot

Copy link
Copy Markdown
Contributor


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA


You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot.

@withfig-bot

Copy link
Copy Markdown
Contributor

Overview

src/aws.ts:

Info:

Single Functions:

postProcess:

 function (out) {
    if (out.trim() == "") {
      return [];
    }
    return out.split("\n").map((line) => ({
      name: line,
      icon: "👤",
    }));
  }

URLs:

  • https://bcm-data-exports.us-east-1.api.aws
  • https://bcm-pricing-calculator.us-east-1.api.aws
  • https://billing.us-east-1.api.aws
  • https://budgets.amazonaws.com
  • https://ce.us-east-1.amazonaws.com
  • https://service.chime.aws.amazon.com.
  • https://cost-optimization-hub.us-east-1.amazonaws.com
  • https://elasticbeanstalk.s3.amazonaws.com/doc/2010-12-01/AWSElasticBeanstalk.wsdl.
  • https://freetier.us-east-1.api.aws
  • https://invoicing.us-east-1.api.aws
  • https://organizations.us-east-1.amazonaws.com
  • http://aws.amazon.com/simpledb/
  • https://tools.ietf.org/html/rfc8628)
  • https://tax.us-east-1.amazonaws.com
  • http://docs.aws.amazon.com/cli/latest/userguide/cli-chap-getting-started.html

@withfig-bot

Copy link
Copy Markdown
Contributor

Hello @ump45nose,
thank you very much for creating a Pull Request!
Here is a small checklist to get this PR merged as quickly as possible:

  • Do all subcommands / options which take arguments include the args property (args: {})?
  • Are all options modular? E.g. -a -u -x instead of -aux
  • Have all other checks passed?

Please add a 👍 as a reaction to this comment to show that you read this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[aws] Add help subcommand

2 participants