Repository navigation
fix: reserve fullOutput instead of verbose for global options - #263
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
=======================================
Coverage ? 95.34%
=======================================
Files ? 36
Lines ? 4987
Branches ? 1936
=======================================
Hits ? 4755
Misses ? 186
Partials ? 46 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The built-in `--verbose` flag was renamed to `--full-output`, but the reserved global option names were not updated. A CLI could not declare a `verbose` global even though nothing consumes `--verbose`, while a `fullOutput` global was accepted but never set because the built-in flag consumes `--full-output` first.
brendanjryan
force-pushed
the
fix/verbose-global-name
branch
from
October 21, 2026 15:37
1b81d9d to
c55d01f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When the built-in
--verboseflag was renamed to--full-output, the reserved global option names were not updated. A CLI could not declare averboseglobal even though nothing consumes--verbose, while afullOutputglobal was accepted but never set, because the built-in flag consumes--full-outputbefore globals are parsed.Summary
verbosewithfullOutputin the reserved global option namesfullOutputin the builtin-conflict test table and add a test for averboseglobalKey design considerations
fullOutputglobal now fails atCli.create()time instead of silently never receiving the value