Repository navigation
Conversation
Contributor
Author
|
Working example can be found at: Joris29/puppet-rundeck#1 |
marcusdots
approved these changes
Oct 26, 2026
marcusdots
left a comment
marcusdots
left a comment
There was a problem hiding this comment.
I think the idea is awesome. I recommend to fix rubocop and continue with this idea.
Joris29
force-pushed
the
msync_exec_git
branch
from
October 27, 2026 13:17
6158f81 to
3b79f84
Compare
Joris29
force-pushed
the
msync_exec_git
branch
from
October 27, 2026 13:18
3b79f84 to
882be9d
Compare
Joris29
marked this pull request as ready for review
October 27, 2026 13:33
marcusdots
requested changes
Oct 27, 2026
marcusdots
left a comment
marcusdots
left a comment
There was a problem hiding this comment.
Could you please fix the scope with a solution of your liking and I will approve this PR?
| changed_files = [status.changed, status.added, status.deleted, repo.untracked_unignored_files].flat_map(&:keys).uniq | ||
| pushed = puppet_module.repository.submit_changes(changed_files, @options) | ||
| end | ||
| @options[:pr] && (pushed || puppet_module.pull_request_branch_ready?) && puppet_module.open_pull_request |
There was a problem hiding this comment.
pushed is a violation of scope. pushed gets created in another nested if that may never be reached.
| warn message | ||
| end | ||
|
|
||
| if result |
There was a problem hiding this comment.
Suggested change
| if result | |
| if result | |
| pushed = nil |
|
I would like to add one request:
gets satisfied? |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.