Repository navigation
Support DOM changes during #solidus_select helper execution - #6707
Merged
jarednorman merged 1 commit intoOct 23, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6707 +/- ##
=======================================
Coverage 92.46% 92.46%
=======================================
Files 1058 1058
Lines 21495 21495
=======================================
Hits 19875 19875
Misses 1620 1620 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
benjaminwil
marked this pull request as ready for review
October 21, 2026 23:15
tvdeyen
approved these changes
Oct 22, 2026
jarednorman
requested changes
Oct 22, 2026
jarednorman
left a comment
jarednorman
left a comment
Member
There was a problem hiding this comment.
One nit. Otherwise looks good!
Sometimes, a select component will be used to trigger a change to the DOM via a Stimulus controller. Sometimes that means that the select element itself could be replaced. If we don't re-find the elements during the `#solidus_select` helper method, then we end up erroring out due to a `Selenium::WebDriver::Error::StaleElementReferenceError`.
benjaminwil
force-pushed
the
solidus-select-dom-replacement
branch
from
October 23, 2026 16:25
9935dd7 to
015442a
Compare
jarednorman
approved these changes
Oct 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sometimes, a select component will be used to trigger a change to the DOM via a Stimulus controller. Sometimes that means that the select element itself could be replaced.
If we don't re-find the elements during the
#solidus_selecthelper method, then we end up erroring out due to aSelenium::WebDriver::Error::StaleElementReferenceError.Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: