Repository navigation
Conversation
github-actions
Bot
added
the
changelog:solidus_core
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6663 +/- ##
=======================================
Coverage 92.47% 92.48%
=======================================
Files 1065 1065
Lines 21541 21543 +2
=======================================
+ Hits 19921 19923 +2
Misses 1620 1620 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
senemsoy
force-pushed
the
senem/fix-shipment-item-cost
branch
2 times, most recently
from
October 20, 2026 18:59
1edf548 to
2c6b205
Compare
senemsoy
changed the title
senemsoy
changed the title
item_cost for split shipments
senemsoy
marked this pull request as ready for review
October 20, 2026 20:43
jarednorman
requested changes
Oct 20, 2026
jarednorman
left a comment
jarednorman
left a comment
Member
There was a problem hiding this comment.
Could you also update the commit message to properly explain the issue that we're fixing with this commit? There's no mention of the bug, split shipments, or issue 2919. Also (just a nit) the commit should be worded so that it says what it does, not what it is "is going to" do.
senemsoy
force-pushed
the
senem/fix-shipment-item-cost
branch
2 times, most recently
from
October 21, 2026 16:41
c43927b to
96fc5b0
Compare
jarednorman
approved these changes
Oct 21, 2026
Currently when a line item's units are split across shipments, `item_cost` returns the full line item total for every shipment that has some of those units, instead of only the part that is in that shipment. Now we calculate shipment's `item_cost` from the units it actually contains. Fixes solidusio#2919 Co-authored-by: Alistair Norman <alistair@super.gd>
senemsoy
force-pushed
the
senem/fix-shipment-item-cost
branch
from
October 23, 2026 19:54
96fc5b0 to
2bacc86
Compare
mamhoff
reviewed
Oct 25, 2026
mamhoff
left a comment
mamhoff
left a comment
Contributor
There was a problem hiding this comment.
Should we make the struct a class at this point?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #2919. We just cleaned up the work done in nebulab#18 and now this is ready for review.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: