Repository navigation
Add ASan in CI and fix some bugs - #23
Merged
Merged
Conversation
…by ensuring string lengths match as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ASan in CI is a good idea; it's a cheap check in Linux to possibly catch memory issues. Indeed, running it revealed some bugs that are fixed in the first commit.
But this PR also holds some bugfixes that were discovered through non-ASan approaches:
deserializeChangesthat could've resulted in corrupted undo history when restoring a buffer from a previous session.baseTextMatchesFilethat allowed for false positives if the two compared strings’ lengths differed.The latter is important to fix as part of implementing
TextBuffer::resurrectproperly in@pulsar-edit/text-buffer.