Repository navigation
fix: avoid a double separator in automatic uploads remote path - #5033
Open
RaphaelFakhri wants to merge 2 commits into
Open
RaphaelFakhri wants to merge 2 commits into
RaphaelFakhri wants to merge 2 commits into
Conversation
Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
|
|
Signed-off-by: Raphael Fakhri <153192858+RaphaelFakhri@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues
App: Refs #4451
Folders picked as the automatic uploads destination store their remote path with a trailing separator (for example,
/Bbbbb/).AutomaticUploadsWorkerthen appends another separator before the file name, so every picture or video upload targets a path such as/Bbbbb//PXL_20240819_120404334.jpg. That doubled path is stored in the transfers table and sent in thePUTrequest, as seen in the logs in the issue.This change composes the remote path through
FolderBackUpConfiguration.getRemotePathForFile(), which trims a trailing separator from the upload path before appending the file name. Configurations saved before this change (with or without a trailing separator, and the root folder/) now produce a single separator.ReleaseNotesViewModel.ktcreating a newReleaseNote()with String resources (if required): not requiredQA
FolderBackUpConfigurationTestcovers upload paths without a trailing separator, with a trailing separator, and the root folder. The last two fail without the fix../gradlew detekt :owncloudDomain:testDebugUnitTest :owncloudApp:compileOriginalDebugKotlinpasses./<folder>/<file>with a single separator.