Repository navigation
types: preserve cached prompt token counts - #774
Open
shuaiyafei wants to merge 1 commit into
Open
shuaiyafei wants to merge 1 commit into
shuaiyafei wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #773.
Declare
prompt_eval_cached_countonBaseGenerateResponsesoGenerateResponseandChatResponsepreserve the cache metric already returned by the server. It defaults toNonewhen absent; an explicit zero is preserved.The field matches the server's
Metrics.PromptEvalCachedCountand the generate/chat response definitions indocs/openapi.yaml. This changes no request parameters or client control flow.Validation
python -m pytest ollama tests -q: 136 passed.ruff format --check .: 43 files already formatted.ruff check .andgit diff --check: passed.Client tests use a local HTTP test server and the real SDK request/response parsing. No live model inference was run. Environment: Python 3.12.15, locked runtime dependencies.
AI assistance: Codex investigated the issue, implemented the change, and ran the checks above.