Repository navigation
Fix completions still using 1-based split column names - #1295
Open
qodelicious wants to merge 1 commit into
Open
qodelicious wants to merge 1 commit into
qodelicious wants to merge 1 commit into
Conversation
split column now names its columns from column0. cargo packages now reads packages.name from cargo metadata, since workspace_members ids no longer have a space separated name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same thing as the modules fix, a few completions still used 1-based
split columnnames.nu-complete cargo packagessplitworkspace_memberson spaces and tookcolumn1. Newer cargo ids look likepath+file:///path/to/foo#0.1.0with no space, and the name is left out when it matches the folder, so this errored. It now readspackages.namefrom the samecargo metadata --no-depsoutput, which only has the workspace members anyway.scoopAliasesgot an empty string per alias instead of the alias namenu-complete subcommandsasked forcolumn2after splitting onSUBCOMMANDS:, which iscolumn1nowTested with stub
cargo,scoopandzellijcommands on nu 0.116.1. Before, cargo and zellij error and scoop returns["", ""]. After, they return the package names,[up, rm]and[action, attach, kill-session]. Also checked cargo against a real workspace.toolkit check prpasses.I left winget alone since #1183 rewrites that file.