Repository navigation
Fix ssh completions for Include lines with comments or ~ paths - #1291
Merged
Merged
Conversation
Trailing comments on Include and Host lines were treated as part of the value, ~ in Include paths wasn't expanded, and only the first file on an Include line was read. Fixes nushell#1124
Contributor
|
ok, thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1124
The ssh completer skipped a lot of Include lines. A few things were going wrong in
ssh-completions.nuInclude other.sshconfig # extra hostswas read as part of the file name~in an Include path wasn't expanded, soInclude ~/.ssh/config.d/*got joined onto~/.sshand never matchedHost github.com # workadded#and the comment words as host namesRelative paths still resolve next to the config file like before, and quoted paths with spaces still work.
Tested with nu 0.116.2 and a throwaway HOME with a config that has all of the above. Before the change only
github.com,#andGitHubcame back. After it the hosts from all four included files show up and the stray#entries are gone. A plain config without any Include gives the same result as before.