Repository navigation
fix(arborist): validate lockfile edges behind workspace links - #9985
Open
manzoorwanijk wants to merge 1 commit into
Open
manzoorwanijk wants to merge 1 commit into
manzoorwanijk wants to merge 1 commit into
Conversation
manzoorwanijk
marked this pull request as ready for review
September 15, 2026 09:53
manzoorwanijk
force-pushed
the
fix/workspace-lockfile-edge-validation
branch
from
October 5, 2026 05:55
4e96d6d to
86f2ca0
Compare
manzoorwanijk
added a commit
to WordPress/gutenberg
that referenced
this pull request
Oct 5, 2026
Root eslint@10 did not satisfy eslint-plugin-react, eslint-plugin-import and eslint-plugin-jsx-a11y peer ranges, and type-fest@0.6.0 did not satisfy the @pmmmwh/react-refresh-webpack-plugin peer range. npm install never repaired these edges behind workspace links (npm/cli#9977), so strict-peer-deps passed. Regenerated with npm/cli#9985.
manzoorwanijk
added a commit
to WordPress/gutenberg
that referenced
this pull request
Oct 5, 2026
* Repair invalid peer dependencies in the lockfile Root eslint@10 did not satisfy eslint-plugin-react, eslint-plugin-import and eslint-plugin-jsx-a11y peer ranges, and type-fest@0.6.0 did not satisfy the @pmmmwh/react-refresh-webpack-plugin peer range. npm install never repaired these edges behind workspace links (npm/cli#9977), so strict-peer-deps passed. Regenerated with npm/cli#9985. * Keep ESLint 10 for plugins with outdated peer ranges eslint-plugin-react, eslint-plugin-import and eslint-plugin-jsx-a11y cap their eslint peer at v9, which made npm resolve a second eslint@9 for every hoisted plugin. They already run on ESLint 10 through fixupPluginRules, so override the peer instead. Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
peterwilsoncc
pushed a commit
to peterwilsoncc/gutenberg-build
that referenced
this pull request
Oct 5, 2026
* Repair invalid peer dependencies in the lockfile Root eslint@10 did not satisfy eslint-plugin-react, eslint-plugin-import and eslint-plugin-jsx-a11y peer ranges, and type-fest@0.6.0 did not satisfy the @pmmmwh/react-refresh-webpack-plugin peer range. npm install never repaired these edges behind workspace links (npm/cli#9977), so strict-peer-deps passed. Regenerated with npm/cli#9985. * Keep ESLint 10 for plugins with outdated peer ranges eslint-plugin-react, eslint-plugin-import and eslint-plugin-jsx-a11y cap their eslint peer at v9, which made npm resolve a second eslint@9 for every hoisted plugin. They already run on ESLint 10 through fixupPluginRules, so override the peer instead. Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Source: WordPress/gutenberg@b46b0c9
manzoorwanijk
force-pushed
the
fix/workspace-lockfile-edge-validation
branch
from
October 13, 2026 08:43
86f2ca0 to
a832276
Compare
peterwilsoncc
pushed a commit
to peterwilsoncc/gutenberg-build
that referenced
this pull request
Oct 14, 2026
* Repair invalid peer dependencies in the lockfile Root eslint@10 did not satisfy eslint-plugin-react, eslint-plugin-import and eslint-plugin-jsx-a11y peer ranges, and type-fest@0.6.0 did not satisfy the @pmmmwh/react-refresh-webpack-plugin peer range. npm install never repaired these edges behind workspace links (npm/cli#9977), so strict-peer-deps passed. Regenerated with npm/cli#9985. * Keep ESLint 10 for plugins with outdated peer ranges eslint-plugin-react, eslint-plugin-import and eslint-plugin-jsx-a11y cap their eslint peer at v9, which made npm resolve a second eslint@9 for every hoisted plugin. They already run on ESLint 10 through fixupPluginRules, so override the peer instead. Co-authored-by: manzoorwanijk <manzoorwanijk@git.wordpress.org> Co-authored-by: tyxla <tyxla@git.wordpress.org> Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org> Source: WordPress/gutenberg@b46b0c9
manzoorwanijk
force-pushed
the
fix/workspace-lockfile-edge-validation
branch
3 times, most recently
from
October 16, 2026 06:54
450ae4e to
ed4e4ec
Compare
manzoorwanijk
force-pushed
the
fix/workspace-lockfile-edge-validation
branch
from
October 16, 2026 07:01
ed4e4ec to
8247f2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With a lockfile,
npm installnever repaired invalid or missing deps reached through a workspace, so--strict-peer-depspassed on a tree thatnpm lsreports asinvalid.#initTreescans the loaded tree throughedge.to, and a workspace edge points at aLink, which has noedgesOut, so the scan stopped at every workspace.The scan in build-ideal-tree.js now starts at the root target and walks into link targets inside the project, matching
#resolveLinks, which also covers a symlinked project root.Workspace-owned deps now behave like root-owned deps: a peer conflict left by
--legacy-peer-depsfails withERESOLVEunless that flag or--forceis used.References
Fixes #9977