Repository navigation
fix(arborist): block symlink escape in patch applier - #10129
Open
rootvector2 wants to merge 1 commit into
Open
rootvector2 wants to merge 1 commit into
rootvector2 wants to merge 1 commit into
Conversation
|
Block symlink and use CI/CD |
|
Disreguard unknown and block bad actor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
applyPatchToDirin@npmcli/arboristapplies a registeredpatchedDependenciespatch to a package that was just extracted from a registry tarball, andcontainedTargetis meant to keep every write and delete inside that package directory. The check is purely lexical (reject..and absolute paths), so a publisher who ships a tarball with a symlink such asevil -> /outsideat a directory the patch touches gets past it: the diff pathevil/pwned.jslooks contained, but the followingwriteFile/rmfollows the symlink and lands outside the package duringnpm install/npm ci. This reworks the guard to refuse a symlink at the target and to require the real path of the deepest existing ancestor to stay inside the real package directory, which is the only layer that sees the extracted tree.Added regression tests for the write and delete cases; both escape on the current tree and are blocked with the fix.