Repository navigation
Enable cleaning up toolcache bundles by default - #4242
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bf883d4-ecd7-4428-970f-86895f760571
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 9bf883d4-ecd7-4428-970f-86895f760571
Contributor
There was a problem hiding this comment.
Warning
- Copilot's review of this pull request may be incomplete because some of the changed files are excluded by your Copilot content exclusion settings. See Excluding content from Copilot for details.
🔵 Needs a closer look
Removing the cleanup disable switch warrants human confirmation of rollout telemetry.
0 open findings
What changed in this PR
Makes CodeQL toolcache cleanup the default on eligible GitHub-hosted runners to reclaim disk space for analysis.
Changes:
- Removes the cleanup feature flag and environment override while retaining existing safeguards.
- Updates tests and the multi-language autodetection check template for the new default.
| File | Description |
|---|---|
| src/setup-codeql.ts | Removes feature gating from bundle cleanup. |
| src/setup-codeql.test.ts | Updates cleanup tests and injected environments. |
| src/feature-flags.ts | Removes the cleanup flag and override configuration. |
| pr-checks/checks/multi-language-autodetect.yml | Removes the obsolete cleanup override. |
Files excluded by content exclusion policy (2)
- .github/workflows/__multi-language-autodetect.yml
- lib/entry-points.js
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
henrymercer
marked this pull request as ready for review
October 15, 2026 20:02
mbg
approved these changes
Oct 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR graduates the
cleanup_toolcache_bundlesfeature flag and removes theCODEQL_ACTION_CLEANUP_TOOLCACHE_BUNDLESoverride.Risk assessment
For internal use only. Please select the risk level of this change:
Which use cases does this change impact?
Workflow types:
dynamicworkflows (Default Setup, Code Quality, ...).Products:
analysis-kinds: code-scanning.analysis-kinds: code-quality.Environments:
github.comand/or GitHub Enterprise Cloud with Data Residency.How did/will you validate this change?
.test.tsfiles).pr-checks).If something goes wrong after this change is released, what are the mitigation and rollback strategies?
How will you know if something goes wrong after this change is released?
codeql-action/toolcache-bundle-cleanupdiagnostic reports deleted versions and whether cleanup failed.Are there any special considerations for merging or releasing this change?
Merge / deployment checklist