Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6304 +/- ##
========================================
Coverage 84.78% 84.78%
========================================
Files 358 358
Lines 38946 38946
Branches 10917 11019 +102
========================================
Hits 33022 33022
Misses 5488 5488
Partials 436 436 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
7f08cc0 to
3f3576e
Compare
canova
left a comment
There was a problem hiding this comment.
Thanks, adding drive by comments but will review a bit more carefully soon.
There was a problem hiding this comment.
Thanks for working on automating the deploymet! It's going to improve our lives a lot.
I think it would be great to add a --dry-run flag that prints each action that would change anything in GitHub or npm instead of really doing it. That would allow me or anyone to also test locally without having to worry about doing these. I was a bit scared to run it right now since I don't know what it would change. Could you add that?
| } | ||
| } | ||
|
|
||
| async function mergePullRequest( |
There was a problem hiding this comment.
Yes, but for the happy path only for now.
|
Ah, btw not for this PR but I thought it would be a nice improvement for later: there is a new terminal protocol getting popular (that only a few terminals implemented so far) to tell the status of the program: https://mitchellh.com/writing/program-status-osc7501 This is the doc of that OSC sequence: https://www.superlogical.com/rex/docs/build/program-status |
Replace the manual first four release steps with an interactive local workflow. It discovers remotes, coordinates reviewed pull requests, generates production notes, and publishes the CLI after deployment. Per-action confirmations and dry-run mode make shared-state changes explicit before they happen.
|
Thanks a lot for the very thorough review, @canova! I've now addressed all the comments you left, including adding the |
Main | Deploy preview
Replace the first 4 steps of the deployment workflow with an automated interactive local script. It coordinates the l10n, CLI version, and production pull requests while preserving approvals, checks, and intended merge methods. Every step requires explicit confirmation.
This script was successfully tested during the October 13 deployment.
The 5th step will be handled as a follow-up.
Closes #5995