Repository navigation
fix: improve Docs table menus and comment interactions - #7871
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7871 +/- ##
==========================================
- Coverage 81.33% 81.33% -0.01%
==========================================
Files 3088 3088
Lines 199924 200031 +107
Branches 51894 51608 -286
==========================================
+ Hits 162602 162689 +87
- Misses 37262 37282 +20
Partials 60 60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
paulreit77-ctrl
approved these changes
Oct 14, 2026
paulreit77-ctrl
approved these changes
Oct 14, 2026
paulreit77-ctrl
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep the whole-table menu accessible while a Docs table is focused, and let users select comment text and open saved hyperlinks.
ParagraphSettingMenuFactoryfor the companion Pro table-context integration. Existing menu callers retain their default behavior; no model schema changes or breaking changes are introduced.No linked issue; these changes address user-reported Docs and comment interaction problems.
Companion PR and merge order
Companion Pro PR: https://github.com/dream-num/univer-pro/pull/5795
Merge this OSS PR first. Then let the repository workflow synchronize the Univer submodule reference into Pro before making the Pro PR ready. The Pro PR does not commit the submodule gitlink manually.
Validation
tsc --noEmitand their package bundle builds (univer-cli build).For manual verification, focus a table after preceding text, open its T menu, and dismiss the panel with Escape or an outside click. Check that the trigger remains available while the table stays focused, that a hovered paragraph does not replace its target, and that permissions and document disposal remove it. Drag a final table and undo/redo the move. In a comment, select text and activate a saved hyperlink; selection should remain intact and the link should open without navigating the document to the comment.
Pull Request Checklist