Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
truncate_str("e\u{301}xy", 1, "")currently returns plaine, dropping its combining acute accent. The ANSI-aware path stops as soon as the column budget is reached; the non-ANSI path already keeps following zero-width characters.Continue until the next character would exceed the budget. Regression cases cover combining marks, multiple marks, CJK, tail budgets, zero width and ANSI resets. The borrowed fast path is unchanged. This retains the existing scalar-width semantics; it does not add grapheme-cluster truncation.
Validation: the regression fails on unmodified main and passes with the fix. All seven
make testfeature configurations,make check,make doc, Clippy with warnings denied, and formatting pass on macOS. A separate public-API consumer confirms ANSI/non-ANSI output parity and unchangedCow::Borrowedcases. Other platforms and MSRV remain upstream CI checks.Prepared with Codex assistance; independently reviewed by a second agent before submission.