Repository navigation
Fix event durations, mobile tab reloads, timeline seeks, fps stat - #364
Merged
Merged
Conversation
- Events use the server-provided media_duration when available, falling back to updated - published when missing or zero (#296) - Notify as mobile tab players are created so tiles no longer stay empty until a manual reload (#341) - Debounce timeline scrub seeks; serialize overlapping setDataSource calls; drop duplicate player subscriptions on re-open (#363) - Report the real codec frame rate on desktop instead of hardcoded 0.0, and stop throwing on Pi (diagnostic for #345)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Batch of issue fixes:
media_durationwhen available, falling back toupdated - publishedwhen it is missing or zero (the server reports 0 for unknown). AddsEvent.mediaDurationplus parsing in the JSON feed branch.initializeDevicesnow notifies as each player is created.setDataSourcecalls are serialized; re-opens no longer accumulate duplicate player subscriptions.Verification:
flutter analyzeclean, full suite 36/36 green including newevent_duration_test.dartanddebouncer_test.dart.Closes #296
Closes #341
Closes #363