Repository navigation
Fix abort when overwriting existing properties via JS_SetPropertyFunctionList. - #572
Open
vanzomerenc wants to merge 1 commit into
Open
vanzomerenc wants to merge 1 commit into
vanzomerenc wants to merge 1 commit into
Conversation
…back to JS_DefinePropertyValue. One of the places where auto-init properties are used is JS_SetPropertyFunctionList, which user code may call on an existing object that may already have some of the properties in a given list.
vanzomerenc
marked this pull request as draft
October 19, 2026 02:48
vanzomerenc
marked this pull request as ready for review
October 19, 2026 03:53
Author
|
This change also means that calling some of the JS_AddIntrinsic[...] functions twice won’t abort anymore, but aborting in that case was probably a good thing because they clearly weren’t meant to be called twice. I’m not sure what would be the best thing to do about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When JS_DefineAutoInitProperty encounters an existing property, fall back to JS_DefinePropertyValue.
One of the places where auto-init properties are used is JS_SetPropertyFunctionList, which user code may call on an existing object that may already have some of the properties in a given list.