Skip to content

fix(plugins): 修复已安装任务插件搜索与分页 - #8053

Open
ceezyyy wants to merge 2 commits into
QuantumNous:mainfrom
ceezyyy:fix/upstream-plugin-search-20261027
Open

ceezyyy wants to merge 2 commits into
QuantumNous:mainfrom
ceezyyy:fix/upstream-plugin-search-20261027

Conversation

@ceezyyy

@ceezyyy ceezyyy commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

问题

已安装任务插件搜索不筛选列表,分页也未按匹配结果计算。

改动

显式使用 includesString,让分页跟随筛选结果;补充卡片、表格和跨页搜索回归。

验证

原版 11 个内置插件搜索 google 仍显示 11 项,修复后为 2 项。320 项相关测试、类型检查、lint、格式检查和生产构建通过。

Summary by CodeRabbit

  • Bug Fixes
    • Plugin search now filters names and keys consistently in both card and table views, including when starting from a later table page. Pagination reflects filtered results, and clearing the search restores the full list.

@coderabbitai

coderabbitai Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: dc333512-eb4b-4862-87cf-ab00ea20240e
Commits

Reviewing files that changed from the base of the PR and between 34003e9 and 361fd10.

Files selected for processing: 2
  • web/src/features/task-plugins/__tests__/plugins-table.test.tsx
  • web/src/features/task-plugins/components/plugins-table.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

PluginsTable now uses string-based global filtering. Tests cover plugin name and key searches, empty results, clearing searches, and filtered pagination.

Changes

Task plugin filtering

Layer / File(s) Summary
Filtering and pagination
web/src/features/task-plugins/components/plugins-table.tsx, web/src/features/task-plugins/__tests__/plugins-table.test.tsx
PluginsTable uses includesString for global filtering. Tests cover name and key searches in card and table views, empty results, clearing searches, and filtered pagination.

Priority: Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Possibly related PRs

  • QuantumNous/new-api#8051: Updates PluginsTable global filtering and related regression tests. This PR also covers filtered pagination.

Suggested reviewers: calcium-ion

Merge Risk: Minimal · up to 361fd

The filtering and pagination change is ready to merge after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within survi… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the main changes: fixing search and pagination for installed task plugins.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 2 functions across 2 files.

Resolution

Write docstrings for the functions missing them to satisfy the coverage threshold.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit taps a plugin key,
Then finds the names that match with glee.
The pages shrink, the filters clear,
All plugins hop back into view.
A quiet search makes browsing clear.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant