Skip to content

fix(workflows): route invocations to the workflow host - #320

Draft
Kayvan-Zahiri wants to merge 1 commit into
PipedreamHQ:mainfrom
Kayvan-Zahiri:codex/route-workflow-invocations-to-workflow-host
Draft

Kayvan-Zahiri wants to merge 1 commit into
PipedreamHQ:mainfrom
Kayvan-Zahiri:codex/route-workflow-invocations-to-workflow-host

Conversation

@Kayvan-Zahiri

Copy link
Copy Markdown

Workflow invocations currently pass their absolute URL as the generated HTTP wrapper's relative path. The wrapper concatenates that with the Pipedream API base URL, so a call to https://workflow.example.com/run goes to https://api.pipedream.com/https:/workflow.example.com/run.

Pass the resolved workflow URL as the per-request base_url, with no relative path, in the custom sync and async workflow clients. This keeps the fix in hand-maintained code. Existing authentication selection and external-user headers remain covered.

Adds 20 offline HTTPX MockTransport regression cases across sync/async invocation, ordinary/external-user invocation, full HTTP(S) URLs, bare hosts, endpoint IDs, custom workflow domains, query strings, and an API base URL with a path prefix. The test file is protected in .fernignore.

Validation:

  • All 20 new cases fail before the fix; all pass afterward.
  • Full suite: 89 passed, 4 skipped (optional aiohttp dependencies and existing unimplemented test).
  • Changed files: Ruff lint/format, mypy, and git diff --check pass.
  • Wheel build succeeds.
  • Full-repository Ruff and mypy retain existing failures, reproduced with the original workflow source: 3 lint findings and 3 type errors in the generated Pydantic utilities. The changed-file lint correction removes one existing import-order finding.

No live workflow or API requests were made.

@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant