Repository navigation
fix(workflows): route invocations to the workflow host - #320
Draft
Kayvan-Zahiri wants to merge 1 commit into
Draft
Kayvan-Zahiri wants to merge 1 commit into
Kayvan-Zahiri wants to merge 1 commit into
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workflow invocations currently pass their absolute URL as the generated HTTP wrapper's relative
path. The wrapper concatenates that with the Pipedream API base URL, so a call tohttps://workflow.example.com/rungoes tohttps://api.pipedream.com/https:/workflow.example.com/run.Pass the resolved workflow URL as the per-request
base_url, with no relative path, in the custom sync and async workflow clients. This keeps the fix in hand-maintained code. Existing authentication selection and external-user headers remain covered.Adds 20 offline HTTPX MockTransport regression cases across sync/async invocation, ordinary/external-user invocation, full HTTP(S) URLs, bare hosts, endpoint IDs, custom workflow domains, query strings, and an API base URL with a path prefix. The test file is protected in
.fernignore.Validation:
git diff --checkpass.No live workflow or API requests were made.