Repository navigation
Conversation
Or was there a reason why this has to be an actual file on the filesystem @MehmedGIT
Contributor
|
@kba, an in-memory file is of course a lot better approach. Regarding the flush, I do not remember anymore. Not sure why it was needed. That method was developed around the time when the logging was still bugged and I tried different approaches till it worked. If the proposed change works fine and do not break anything in the logging, then it is good! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Or was there a reason why this has to be an actual file on the filesystem. and why the flush? @MehmedGIT