Skip to content

Deprecate RetryableQuery variants ahead of V6 removal - #376

Open
gabisonia wants to merge 2 commits into
BrighterCommand:masterfrom
gabisonia:fix/348-obsolete-retryable-query
Open

gabisonia wants to merge 2 commits into
BrighterCommand:masterfrom
gabisonia:fix/348-obsolete-retryable-query

Conversation

@gabisonia

Copy link
Copy Markdown
Member

Deprecate RetryableQueryAttribute, RetryableQueryAttributeAsync, and their public decorators in V5 so consumers can migrate before removal in V6. Each type now emits an Obsolete warning naming its resilience pipeline replacement; legacy execution and policy registration remain supported.

Update the README examples and migration guidance to use resilience pipelines, and suppress obsolete warnings only at intentional legacy registration and test usages.

Closes #348.

Validation

  • dotnet build Darker.Filter.slnf -c Release --nologo passed with existing unrelated warnings.
  • DOTNET_ROLL_FORWARD=Major dotnet test Darker.Filter.slnf -c Release --no-restore --no-build --nologo: 704 passed. Both .NET 8 and .NET 9 test targets ran on the installed .NET 10 runtime using roll-forward; native runtime validation remains for CI.
  • A separate temporary consumer project produced all four expected CS0618 warnings and successfully retried transient failures through both sync and async replacement pipelines using the documented DI registration.
  • git diff --check passed.

@iancooper iancooper left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gabisonia

@iancooper

Copy link
Copy Markdown
Member

Thanks @gabisonia

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 - Done .NET Pull requests that update .net code V5

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make RetryableQuery and variants Obsolete

2 participants