Repository navigation
llminternal: OutputSchema mutations leak across requests #1792
Description
Describe the Bug:
basicRequestProcessor assigns state.OutputSchema directly to req.Config.ResponseSchema (source). Both fields reference the same *genai.Schema, so a BeforeModel callback can modify the agent's schema and affect other requests. A shallow struct copy would still share the Properties map and nested schema pointers.
Reproduction:
- Configure an agent with no tools and an
OutputSchemacontaining a string property namedanswer. - In a
BeforeModelcallback, change the request'sanswerproperty type togenai.TypeNumber. - Check the original
OutputSchemaand another request's schema.
Expected: Both still describe answer as a string.
Actual: Both now describe it as a number.
Reproduction test and command
Append this test to internal/llminternal/basic_processor_test.go; it uses the existing imports and test helpers.
func TestBasicRequestProcessor_OutputSchemaIsolation(t *testing.T) {
schema := &genai.Schema{
Type: genai.TypeObject,
Properties: map[string]*genai.Schema{
"answer": {Type: genai.TypeString},
},
}
base, err := agent.New(agent.Config{Name: "testAgent"})
if err != nil {
t.Fatal(err)
}
a := &mockLLMAgent{Agent: base, s: &State{OutputSchema: schema}}
ctx := icontext.NewInvocationContext(t.Context(), icontext.InvocationContextParams{Agent: a})
requests := []*model.LLMRequest{{}, {}}
for _, req := range requests {
for _, err := range basicRequestProcessor(ctx, req, &Flow{}) {
if err != nil {
t.Fatal(err)
}
}
}
// A BeforeModel callback can perform this same request mutation.
requests[0].Config.ResponseSchema.Properties["answer"].Type = genai.TypeNumber
if schema.Properties["answer"].Type != genai.TypeString {
t.Error("request mutation changed the agent's OutputSchema")
}
if requests[1].Config.ResponseSchema.Properties["answer"].Type != genai.TypeString {
t.Error("request mutation changed another request's schema")
}
}Run:
go test -race -mod=readonly -count=1 ./internal/llminternal -run '^TestBasicRequestProcessor_OutputSchemaIsolation$'Related to #1484 and #1546. This assignment bypasses clone, so the fix in #1546 does not address it.
Activity