test: cover env, redirect and reload gaps (#650)

Author: raisedadead

__tests__/instrumentation.test.ts

@@ -0,0 +1,45 @@
+import { register } from '../instrumentation';
+
+const validEnv = {
+  DATABASE_URL: 'postgresql://test-user:test-pass@localhost:5432/test',
+  NEXTAUTH_URL: 'http://localhost:3001',
+  NEXTAUTH_SECRET: 'example-not-for-production'
+};
+
+describe('register', () => {
+  const originalEnv = process.env;
+
+  beforeEach(() => {
+    process.env = { ...validEnv, NODE_ENV: 'test', NEXT_RUNTIME: 'nodejs' };
+    vi.spyOn(console, 'error').mockImplementation(() => {});
+    vi.spyOn(process, 'exit').mockImplementation(() => undefined as never);
+  });
+
+  afterEach(() => {
+    process.env = originalEnv;
+    vi.restoreAllMocks();
+  });
+
+  it('exits with code 1 when the environment is invalid', async () => {
+    delete process.env.DATABASE_URL;
+
+    await register();
+
+    expect(process.exit).toHaveBeenCalledWith(1);
+  });
+
+  it('starts when the environment is valid', async () => {
+    await register();
+
+    expect(process.exit).not.toHaveBeenCalled();
+  });
+
+  it('skips the check outside the Node.js runtime', async () => {
+    process.env.NEXT_RUNTIME = 'edge';
+    delete process.env.DATABASE_URL;
+
+    await register();
+
+    expect(process.exit).not.toHaveBeenCalled();
+  });
+});

__tests__/utils/env.test.ts

@@ -39,6 +39,12 @@ describe('findEnvProblems', () => {
     }
   );
 
+  it('treats an unset NODE_ENV as development', () => {
+    const env: NodeJS.ProcessEnv = { ...developmentEnv };
+    Reflect.deleteProperty(env, 'NODE_ENV');
+    expect(findEnvProblems(env)).toEqual([]);
+  });
+
   it('treats an empty string as not set', () => {
     const env: NodeJS.ProcessEnv = { ...developmentEnv, DATABASE_URL: '' };
     expect(findEnvProblems(env)).toEqual(['DATABASE_URL is not set']);

__tests__/utils/safeCallbackPath.test.ts

@@ -17,7 +17,12 @@ describe('safeCallbackPath', () => {
     ['javascript:alert(1)', '/'],
     ['/.//evil.example', '/'],
     ['/..//evil.example', '/'],
-    ['http://localhost:3001//evil.example', '/']
+    ['http://localhost:3001//evil.example', '/'],
+    ['/%2F%2Fevil.example', '/%2F%2Fevil.example'],
+    ['%2F%2Fevil.example', '/%2F%2Fevil.example'],
+    ['/%5Cevil.example', '/%5Cevil.example'],
+    ['/%2e%2e/%2F%2Fevil.example', '/%2F%2Fevil.example'],
+    ['http%3A%2F%2Fevil.example', '/http%3A%2F%2Fevil.example']
   ])('maps %j to %j', (value, expected) => {
     expect(safeCallbackPath(value, base)).toBe(expected);
   });

e2e/smoke.spec.ts

@@ -57,6 +57,9 @@ test('teacher creates a class', async ({ page }) => {
 
   await expect(dialog).toBeHidden();
   await expect(page.getByText(className, { exact: true })).toBeVisible();
+
+  await page.reload();
+  await expect(page.getByText(className, { exact: true })).toBeVisible();
 });
 
 test('teacher opens the class dashboard', async ({ page }) => {