You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Lab/RGB conversion filters introduced in Xcode 14 were disabled because the original bindings used factory-method names and mapped both filters to a nonexistent CIConvertLab class, causing filter construction and introspection failures.
Expose CIConvertLabToRGB and CIConvertRGBtoLab using their native filter names and the existing shared CIConvertLabProtocol. This preserves separate, strongly typed filters without introducing a shared concrete class. Add them to the handle-based filter lookup, remove their introspection exclusions, and extend the existing documentation baseline.
Regression coverage exercises both conversion directions, named lookup, nullable image input, output-image creation, and normalization round trips.
Bind CIConvertLabToRGB and CIConvertRGBtoLab using their native filter names and the shared CIConvertLab protocol. The previously disabled declarations used factory-method names and incorrectly mapped both filters to a CIConvertLab class, which prevented native filter creation.
Restore introspection coverage, wire the handle-based filter lookup, and add regression coverage for construction, named lookup, image input/output, and normalization. Extend the existing documentation baseline for the new filter types and generated properties.
Fixes#15662
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 41349df9-d66f-40c1-9d7b-e974f10d6d6a
Keep the Lab conversion regression focused on successful native lookup and the selected filter name. CIFilter.FromName returns a CIFilter wrapper rather than promising a concrete generated filter subclass. Create and dispose the input color explicitly using the existing CIColor factory.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 41349df9-d66f-40c1-9d7b-e974f10d6d6a
Allow the Bto fragment produced when the spelling test splits CIConvertRGBtoLab. The managed filter deliberately follows the native filter name, so this fragment is not a spelling mistake.
Apply the eight AppSizeTest baseline diffs posted on PR #26918 for CI build 20261019.17. These update preserved registrar callback identifiers and the macOS CoreCLR app sizes after enabling the two conversion filters.
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 41349df9-d66f-40c1-9d7b-e974f10d6d6a
Add regression coverage for handle-based ConvertLab mapping
src/CoreImage/CIFilter.cs:742
💡 Testing — The new ConvertLab test calls the public FromName(string) binding (filterWithName:), not this internal handle-based overload used by CIImage.WrapFilters. Removing or swapping these cases would leave that test passing. Add regression coverage that exercises this overload for both filter names and asserts the corresponding concrete wrapper type, while preserving native-handle ownership.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Lab/RGB conversion filters introduced in Xcode 14 were disabled because the original bindings used factory-method names and mapped both filters to a nonexistent
CIConvertLabclass, causing filter construction and introspection failures.Expose
CIConvertLabToRGBandCIConvertRGBtoLabusing their native filter names and the existing sharedCIConvertLabProtocol. This preserves separate, strongly typed filters without introducing a shared concrete class. Add them to the handle-based filter lookup, remove their introspection exclusions, and extend the existing documentation baseline.Regression coverage exercises both conversion directions, named lookup, nullable image input, output-image creation, and normalization round trips.
Fixes #15662
🤖 Pull request created by Copilot